Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ROCm backend #3148

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Remove ROCm backend #3148

merged 2 commits into from
Sep 3, 2020

Conversation

masterleinad
Copy link
Contributor

Together with #3135, #3145 and #3147, this pull request removes the ROCm backend.

@DavidPoliakoff
Copy link
Contributor

👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍

dalg24
dalg24 previously requested changes Jul 2, 2020
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge before @Rombur approves

@dalg24
Copy link
Member

dalg24 commented Sep 2, 2020

This can be rebased and merged now.

@masterleinad
Copy link
Contributor Author

Rebased.

@dalg24 dalg24 dismissed their stale review September 3, 2020 13:03

Not blocking PR any more

@masterleinad masterleinad mentioned this pull request Sep 3, 2020
Merged
@dalg24 dalg24 removed the [WIP] label Sep 3, 2020
@dalg24 dalg24 merged commit 062855d into kokkos:develop Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@crtrott crtrott crtrott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@masterleinad @DavidPoliakoff @dalg24 @crtrott