-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dual View Tool Events #3326
Dual View Tool Events #3326
Conversation
Yes!!! I've wanted this for forever, see kokkos/kokkos-tools#11. |
@stanmoore1 , Stan, we're exactly on the same page, I'm just about two years slower. I'm going back through the Kokkos Tools backlog, but we should also have a conversation about anything you want done in the Tools area. The roadmap, fyi:
"If I see an access on the Host copy after a change on the device copy without a sync in the middle" kinds of rules start to become possible. Now I know you've been there for years, but we're catching up! |
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document first what this does. The bool state isn't clear to me. Like why is "onDevice" false when it needed to sync to the host? And why is it true when syncing to the device? I mean what if it is in a valid state either way and so need_sync would be false for both host and device? Is the bool just to mean that foo in sync_foo or modify_foo was device if it is true?
Yes. Do we want a different name, do we want an enum, or what? |
If we just get a comment on the functions what the arguments mean and maybe rename in the sync version the on_device to to_device I am fine. |
…kokkos into feature/dual_view_events
This PR adds Dual View events to the callback interface, and implements them. Current signature (up for debate) are events on sync and modify that pass
Questions I have for reviewers (other than "should this go in")