Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail at configuration time with shared libraries and relocatable device code #3332

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Fail at configuration time with shared libraries and relocatable device code #3332

merged 1 commit into from
Sep 3, 2020

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Sep 2, 2020

Fix #3328

DavidPoliakoff
DavidPoliakoff approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@DavidPoliakoff DavidPoliakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dalg24 dalg24 merged commit a6bf64e into kokkos:develop Sep 3, 2020
@dalg24 dalg24 deleted the rdc_requires_static_libs branch September 3, 2020 02:11
@dalg24 dalg24 mentioned this pull request Sep 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@DavidPoliakoff DavidPoliakoff DavidPoliakoff approved these changes

@crtrott crtrott crtrott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dalg24 @masterleinad @DavidPoliakoff @crtrott