Moved Space EBO helpers to Kokkos_EBO

[dhollman]

This is needed so that Kokkos Graphs don't have to include Kokkos Tasking stuff to do exec space EBO.

[dalg24]

Can be defaulted. Should it be annotated with __host__ __device__ (KOKKOS_DEFAULTED_FUNCTION or similar)?

[dalg24]

inline specifier is superfluous. Should the function be declared with noexcept?

[dhollman]

@dalg24 This is literally code that is already in Kokkos verbatim. Of course I could clean it up, but I've been told to avoid making changes like that when doing something else.

[dalg24]

@dalg24 This is literally code that is already in Kokkos verbatim. Of course I could clean it up, but I've been told to avoid making changes like that when doing something else.

This is fair and you'll notice I just commented and did not request changes.

[DavidPoliakoff]

@dalg24 : how would you feel about a "code-cleanup" label and having comments like this just link to those issues? "This isn't a part of your PR, but I'm opening an issue here [link] to fix this thing I noticed." That way I have a label I can just go through on days when I need a bit of brainless work. Also, the author still has the ability to close them via addressing comments. Might be a little heavy-weight, but I personally like it

…

On Tue, Sep 8, 2020 at 7:07 PM Damien L-G ***@***.***> wrote: @dalg24 <https://github.com/dalg24> This is literally code that is already in Kokkos verbatim. Of course I could clean it up, but I've been told to avoid making changes like that when doing something else. This is fair and you'll notice I just commented and did not request changes. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3357 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAGLSKOVPMF4OMZMS34BXTSE3INBANCNFSM4RAR3HVQ> .

-- Thanks, David