Small change to parallel_reduce fence #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't change any functionality, but it's a refactoring that makes it possible to do some of the necessary checking in the Kokkos Graphs interface, since anything that needs a fence there is not allowed.
dalg24
reviewed
Sep 9, 2020
| template <class ExecutionSpace, class ViewLike> | ||
| constexpr std::enable_if_t< | ||
| // requires Kokkos::ViewLike<ViewLike> | ||
| Kokkos::is_view<ViewLike>::value, |
There was a problem hiding this comment.
I don't get the "view-like". Are you referring to some upcoming changes?
There was a problem hiding this comment.
I didn't want to use the token View because it shadows something in namespace Kokkos. But more to the point: in theory, things like DynRankView should also meet the requirements of ViewLike as a concept. Anyway, it's just a template parameter—don't read too much into it; I've just always thought of the concept for View as being named ViewLike, but do you have a better name for that concept?
dalg24
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change any functionality, but it's a refactoring that makes it possible to do some of the necessary checking in the Kokkos Graphs interface, since anything that needs a
fencethere is not allowed.