Implement multiple occupancy paths for various HIP kernel launchers #3366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned version of #3300:
Ensure that the occupancy checked in Kokkos_HIP_BlockSize_Deduction.hpp matches the kernel launcher used in Kokkos_HIP_KernelLaunch.hpp, i.e., hip_parallel_launch_local_memory. Previously, if the occupancy was determined for the constant launcher, subtle launch-time resource utilization bugs could be introduced (e.g., not enough LDS for the scatchpad) due to minor differences in the kernels.