Fix sigFPE in HIP blocksize deduction #3378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #3333 for testing on ROCm 3.7
The:
in
test_block_deduction_bug_pr_3103
, causes:to be set to 32 (as this takes the 3.7 path). This forces:
to zero, resulting in a sigFPE.
I've also added a guard on
regs_per_wavefront
in case we ever launch a null kernel, andattr.numRegs
is somehow zero.