Kokkos_ViewMapping.hpp: intel workaround for using statement #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
approved these changes
Sep 14, 2020
masterleinad
approved these changes
Sep 14, 2020
DavidPoliakoff
approved these changes
Sep 14, 2020
ndellingwood
force-pushed
the
issue-3381
branch
from
c304157
to
3666203
Compare
|
Apparently failed on format check |
|
Huh, I ran clang-format locally (clang8). Let me try again... |
|
Retest this please |
|
I tried applying clang-format again but did not see a difference, I'm guessing my force-push messed up the CI? s994290:kokkos ndellin$ git log -1
commit 36662031444e10d36f4491f8852205cab15e109c (HEAD -> issue-3381, myfork/issue-3381)
Author: Nathan Ellingwood <ndellin@sandia.gov>
Date: Mon Sep 14 12:57:33 2020 -0600
Kokkos_ViewMapping.hpp: intel workaround for using statement
Temporarily replace using with typedef (and clang-tidy nolint marking)
to workaround intel compiler issue
"error #3186: expected typedef declaration"
Address issue #3381
s994290:kokkos ndellin$ clang-format -i core/src/Kokkos_Macros.hpp core/src/impl/Kokkos_ViewMapping.hpp
s994290:kokkos ndellin$ git status
On branch issue-3381
Your branch is up to date with 'myfork/issue-3381'.
Untracked files:
(use "git add <file>..." to include in what will be committed)
cherry-pick-commits.txt
nothing added to commit but untracked files present (use "git add" to track)
s994290:kokkos ndellin$ clang --version
clang version 8.0.1 (tags/RELEASE_801/final)
Target: x86_64-apple-darwin17.7.0
Thread model: posix
InstalledDir: /opt/local/libexec/llvm-8.0/bin |
dhollman
approved these changes
Sep 14, 2020
core/src/impl/Kokkos_ViewMapping.hpp
Outdated
Comment on lines
2729
to
2732
| // typedef work-around for intel compilers error #3186: expected typedef | ||
| // declaration | ||
| typedef value_type* KOKKOS_IMPL_ALIGN_PTR(KOKKOS_MEMORY_ALIGNMENT) | ||
| handle_type; // NOLINT(modernize-use-using) |
There was a problem hiding this comment.
Does this the pass clang-tidy check? We might have to use NOLINTNEXTLINE or something if not
There was a problem hiding this comment.
Just pushed the NOLINTNEXTLINE change
Temporarily replace using with typedef (and clang-tidy nolint marking) to workaround intel compiler issue "error kokkos#3186: expected typedef declaration" Address issue kokkos#3381
ndellingwood
force-pushed
the
issue-3381
branch
from
3666203
to
98c05d6
Compare
|
@dalg24 @masterleinad is there something I need to do differently for the PR to address the CI failures? There are errors like: OMPTARGET-clang And elsewhere out-of-disk messages during linking attempts: |
|
Not your fault. Both failing jobs ran on fetnat05 with Retest this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily replace using with typedef (and clang-tidy nolint marking)
to workaround intel compiler issue
"error #3186: expected typedef declaration"
Address issue #3381