Do not include link flags for fortran linkage: Issue #3355 #3384
Conversation
jjwilke
force-pushed
the
fortran-link-issue-3355
branch
from
29e4e2a
to
efc4134
Compare
|
Retest this please |
There was a problem hiding this comment.
Looks good to me. I checked that I still see the architecture flag for a C++ target and that the minimal example in #3355 builds fine (without the architecture flag on the link line) for CMake 13 and CMake 18.
|
I assume this also means we don't get the OpenMP flag on the link line? |
|
Should we error out if someone enabled CUDA Relocatable Device code? |
There was a problem hiding this comment.
Two comments: please respond, if you say we can add that later or we just have to leave that to whoever is doing the fortran thing sure. We may want to issue a warning like: "WARNING: You are using a Fortran linker, this may or may not work for a code with Kokkos dependency. Good Luck!"
|
I don't think I can do anything if someone overrides the |
Correct, I am turning off all linker flags from Kokkos when Fortran is the linker. I can be more selective, but the safest and simplest thing to me seemed to be "hey, if you're linking with f90, you're totally on your own". |
|
Ok please add documentation that this is an issue. |
cmake/kokkos_tribits.cmake
Outdated
| ELSEIF(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.13") | ||
| #I can use link options | ||
| #check for CXX linkage in a super complicated way | ||
| SET(IS_STATIC $<STREQUAL:$<TARGET_PROPERTY:TYPE>,STATIC_LIBRARY>) | ||
| #I can't query linker_language on static libraries (and it doesn't matter anyway) | ||
| SET(LINK_TYPE $<${IS_STATIC}:CXX>$<$<NOT:${IS_STATIC}>:$<TARGET_PROPERTY:LINKER_LANGUAGE>>) | ||
| TARGET_LINK_OPTIONS( | ||
| ${LIBRARY_NAME} PUBLIC | ||
| $<$<STREQUAL:${LINK_TYPE},CXX>:${KOKKOS_LINK_OPTIONS}> |
There was a problem hiding this comment.
An alternative would be we only support this with CMake 3.18
There was a problem hiding this comment.
We will discuss this today, but I am also in favor of dropping this elseif branch and converting it back to what it was before. I.e. only support the CXX only linkage with cmake 3.18.
jjwilke
force-pushed
the
fortran-link-issue-3355
branch
from
efc4134
to
86165f4
Compare
jjwilke
force-pushed
the
fortran-link-issue-3355
branch
from
86165f4
to
7a30c15
Compare
Use generator expressions to avoid including linker flags when someone builds with Fortran.
Note:
Should be stable with CMake 3.18.
Iffy on CMake >= 3.13, but complicated to do
Does not work on 3.12. Fortran linkage will require 3.13 and above.
Fixes #3325, fixes #3355.