-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CombinedReducers MDRange support #3395
CombinedReducers MDRange support #3395
Conversation
ffdcc3c
to
9d36a90
Compare
|
Implement feature request in kokkos#3394
9d36a90
to
703b226
Compare
d032d14
to
95de112
Compare
It was added for CombinedReducers MDRangePolicy changes, but I don't need it if I'm going to have to use SFINAE anyway.
95de112
to
d963c01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why aren't you taking advantage of FTAD?
I pulled your changes and I see that my suggestion compiles but produces a bug. Please educate me. |
|
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Ah ok I get it now. |
Implement feature request in #3394