Install hpcbind script: issue #3304 #3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
Sep 21, 2020
|
@crtrott , do we want to maintain these scripts, and promise their effectiveness? If yes, I think this is good, but that's still the question we haven't answered |
|
who is using hpcbind and who is volunteering to maintain it? This was Dan's baby. @nmhamster Si do you think this is a good idea or bad idea (hpcbind)? |
crtrott
previously requested changes
Sep 21, 2020
There was a problem hiding this comment.
Just putting a block on this, I want to hear from @nmhamster how he feels about the script.
|
We had a user in Slack request this a month ago or so, I filed the tracking issue and helpfully didn't name them (oops). I'll see if I can find them in our history |
jjwilke
force-pushed
the
hpcbind-issue-3304
branch
from
5132844
to
46830db
Compare
|
Talked with nmhamster and he agrees its good to install this. Just need to resolve the merge conflict. |
Co-Authored-By: Jeremiah Wilke <jjwilke@sandia.gov>
dalg24
force-pushed
the
hpcbind-issue-3304
branch
2 times, most recently
from
8959420
to
92f8541
Compare
jeffmiles63
reviewed
Oct 7, 2020
Take advantage of the CMake `install` command support Co-Authored-By: Jeremiah Wilke <jjwilke@sandia.gov>
dalg24
force-pushed
the
hpcbind-issue-3304
branch
from
92f8541
to
e158706
Compare
|
Failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.