Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/unit_test: separate cuda timing-based tests into separate exe #3407

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

ndellingwood
Copy link
Contributor

To address issue #3405

@ndellingwood
Copy link
Contributor Author

@crtrott @dalg24 since this change is pretty minimal, should it be cherry-picked to release-candidate-3.2.1 to get into Trilinos towards addressing trilinos/Trilinos#6799 ?

@crtrott
Copy link
Member

crtrott commented Sep 22, 2020

Yeah

Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trilinos/Trilinos#6799 (comment) and
trilinos/Trilinos#6799 (comment) suggest to rename
UnitTest_Cuda3 -> UnitTest_CudaTimingBased
Why did you decide to create a new executable?

@dalg24
Copy link
Member

dalg24 commented Sep 22, 2020

To be clear I don't necessarily have a problem with your solution but you must comment that the changes you propose depart from the resolution that was suggested and why you suggested to do so.

@ndellingwood
Copy link
Contributor Author

Why did you decide to create a new executable

@dalg24 the timing-based tests themselves were already part of the UnitTest_Cuda3 set of tests (which also includes non-timing based tests), so I separated them out into a new executable with the descriptive name UnitTest_CudaTimingBased that can be set to run serially for Trilinos projects that test with some level of parallelism (i.e. ctest -jN). I thought just renaming UnitTest_Cuda3 was a bit misleading since most of the tests do not rely on timing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants