Use bool for enums representing bools #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
enum_bools
branch
from
668a916
to
426d79f
Compare
crtrott
requested changes
Sep 24, 2020
There was a problem hiding this comment.
I want this tested with more compilers than are in the CI @ndellingwood we had issues before with stuff like this.
|
@ndellingwood Would you mind checking if this works for the larger amount of compilers we are testing? |
|
@masterleinad I launched tests with intel compilers (17, 18, 19) and subset of configurations, let me know if we need additional compilers checked as well. |
|
Intel spot-check results from kokkos-dev pass (I cherry-picked a254bdd from develop which created SHA f1dfdcfeb655fe8e54107dc150fedbd76e3cf632 to add intel 18 and 19 testing options) Running on machine: kokkos-dev
Repository Status: f1dfdcfeb655fe8e54107dc150fedbd76e3cf632 update testing scripts for kokkos-dev
Going to test compilers: intel/17.0.1 intel/18.0.5 intel/19.0.5
Testing compiler intel/17.0.1
Testing compiler intel/18.0.5
Starting job intel-17.0.1-OpenMP-release
kokkos options:
kokkos devices: OpenMP
kokkos cxx: -O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized
PASSED intel-17.0.1-OpenMP-release
Testing compiler intel/19.0.5
Starting job intel-18.0.5-Serial-release
kokkos options:
kokkos devices: Serial
kokkos cxx: -O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized
PASSED intel-18.0.5-Serial-release
Starting job intel-19.0.5-Pthread_Serial-release
kokkos options:
kokkos devices: Pthread,Serial
kokkos cxx: -O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized
PASSED intel-19.0.5-Pthread_Serial-release
#######################################################
PASSED TESTS
#######################################################
intel-17.0.1-OpenMP-release build_time=205 run_time=232
intel-18.0.5-Serial-release build_time=166 run_time=326
intel-19.0.5-Pthread_Serial-release build_time=311 run_time=967 |
|
Retest this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids some implicit conversions that would be detected by some static analyzers.