[HIP] enable global lock arrays #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -326,8 +326,6 @@ if(Kokkos_ENABLE_HIP) | |||
| # FIXME_HIP | |||
| LIST(REMOVE_ITEM HIP_SOURCES | |||
| hip/TestHIP_AtomicOperations_complexdouble.cpp | |||
There was a problem hiding this comment.
What's the problem with this test?
There was a problem hiding this comment.
I haven't really investigate the problem with complex numbers yet.
| @@ -121,12 +121,21 @@ void test_team_policy_max_recommended_static_size(int scratch_size) { | |||
| .set_scratch_size(0, Kokkos::PerTeam(scratch_size)), | |||
| FunctorFor<T, N, PolicyType, S>()); | |||
| MyArray<T, N> val; | |||
| double n_leagues = 10000; | |||
| // FIXME_HIP | |||
There was a problem hiding this comment.
Any idea what the issue here is?
There was a problem hiding this comment.
That's the segfault that we reported to AMD and we talked about during the last group meeting
| @@ -477,8 +477,11 @@ bool Test(int test) { | |||
| test_scalar<long long int, ExecutionSpace>(317, team_size, test); | |||
| passed = passed && test_scalar<float, ExecutionSpace>(317, team_size, test); | |||
| passed = passed && test_scalar<double, ExecutionSpace>(317, team_size, test); | |||
| // FIXME_HIP | |||
crtrott
approved these changes
Sep 24, 2020
|
I have open an issue |
|
Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables:
As far as I can tell the tests that still do not pass are tests that either use
complexor tests which pass for smaller sizes.