Replace enums in Kokkos_ViewMapping.hpp

[masterleinad]

Alternative to #3420 to prevent some -Wextra warnings regarding comparing enums and non-enums.

[masterleinad]

Retest this please.

[masterleinad]

Retest this please.

[masterleinad]

Retest this please.

[masterleinad]

This seems to work as well.

[djglaze]

This is a better solution than what I was proposing. I was under the (mistaken) belief that I would have to add a .cpp file to add definitions for these variables. Auto-inlining from the header solves the problem. I will gladly abandon my PR in place of this if it passes review.

[crtrott]

I want some more compiler coverage than what CI does. I tried that before and not all of them ate this. But that was before our switch to requiring C++14 and the associated drop of some compilers. We had CUDA 8 and Intel 15 back then for example. So this might be fine now, and if so I want this solution.

[ndellingwood]

@crtrott @masterleinad I ran a spot-check with a subset of intel compilers + backends on kokkos-dev, no errors/failures.
Note the script changes were to add intel/18 and intel/19 options

[ndellin@kokkos-dev IntelTesting]$ ../../scripts/testing_scripts/test_all_sandia intel --spot-check
Running on machine: kokkos-dev
WARNING!! THE FOLLOWING CHANGES ARE UNCOMMITTED!! :
 M scripts/testing_scripts/test_all_sandia
 M scripts/testing_scripts/update_lib.sh

Repository Status:  5cfafd1af0bf3ccc07559d536cee31f781ee1557 Replace enums in Kokkos_ViewMapping.hpp


Going to test compilers:  intel/17.0.1 intel/18.0.5 intel/19.0.5
Testing compiler intel/17.0.1
Testing compiler intel/18.0.5
  Starting job intel-17.0.1-OpenMP-release
kokkos options: 
kokkos devices: OpenMP
kokkos cxx: -O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized 
  PASSED intel-17.0.1-OpenMP-release
Testing compiler intel/19.0.5
  Starting job intel-18.0.5-Serial-release
kokkos options: 
kokkos devices: Serial
kokkos cxx: -O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized 
  PASSED intel-18.0.5-Serial-release
  Starting job intel-19.0.5-Pthread_Serial-release
kokkos options: 
kokkos devices: Pthread,Serial
kokkos cxx: -O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized 
  PASSED intel-19.0.5-Pthread_Serial-release
#######################################################
PASSED TESTS
#######################################################
intel-17.0.1-OpenMP-release build_time=200 run_time=229
intel-18.0.5-Serial-release build_time=166 run_time=326
intel-19.0.5-Pthread_Serial-release build_time=314 run_time=965

[crtrott]

Ok cool