Fix Zero Length Reduction failures in Kokkos nightlies for Pthreads #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
previously approved these changes
Oct 6, 2020
|
I actually expect this to fail btw ... |
dalg24
dismissed
their stale review
Obviously I misunderstood what the intent of the changes were
crtrott
force-pushed
the
run-pthreads-travis-with-2-threasd
branch
from
bc1ed38
to
0a65382
Compare
crtrott
changed the title
|
Cross-referencing #3433 |
This was referenced Oct 8, 2020
|
Cherry-pick to 3.2.1 |
This was referenced Oct 8, 2020
ndellingwood
pushed a commit
to ndellingwood/kokkos
that referenced
this pull request
Nov 4, 2020
…2-threasd Fix Zero Length Reduction failures in Kokkos nightlies for Pthreads (cherry picked from commit a22552d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is confirming that the issue with the zero length reducer in PThreads is reproduced if we actually use more than one thread for travis pthreads build... Will add fixes later to this PR and rename.