OpenMPTarget: Hierarchial reduction for + operator on scalars. #3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rgayatri23
commented
Oct 20, 2020
rgayatri23
commented
- Hierarchical reduction for scalars.
- Reorganized the incremental tests 12 and 13 to run the parallel_reduce incremental tests before the scratch memory tests.
- Incremental test level increased to 12.
dalg24
reviewed
Oct 21, 2020
janciesko
reviewed
Oct 22, 2020
|
|
||
| #pragma omp simd reduction(+ : tmp_scratch [1:2]) | ||
| ValueType vector_reduce = ValueType(); | ||
| #pragma omp simd reduction(+ : vector_reduce) |
There was a problem hiding this comment.
Consider renaming variable to scalar_reduce as this is for the scalar-type reduction.
There was a problem hiding this comment.
Yeah it is confusing I guess. The reason I named it as vector_reduce is because the reduction is happening over the ThreadVectorRange. I can rename it if you push me strongly over it :-) .
crtrott
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.