Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exception resulting from 0 grain size (Issue #3460) #3510

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

jeffmiles63
Copy link
Contributor

This should resolve issue #3460

Copy link
Contributor

@ndellingwood ndellingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dalg24
Copy link
Member

dalg24 commented Oct 22, 2020

I totally missed that when I opened #3512
I pulled your changes and can confirm that the changes suggested here also resolve the UB I reported
@DavidPoliakoff please review.

@dalg24
Copy link
Member

dalg24 commented Oct 22, 2020

@ndellingwood Would you please check if this resolves #3497

@ndellingwood
Copy link
Contributor

@dalg24 @jeffmiles63 : built Pthreads build with gcc/8.3.0:

[ndellin@kokkos-dev unit_test]$ ./KokkosCore_UnitTest_Threads --gtest_filter=threads.policy_converting_constructor_from_other_policy
Note: Google Test filter = threads.policy_converting_constructor_from_other_policy
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from threads
[ RUN      ] threads.policy_converting_constructor_from_other_policy
[       OK ] threads.policy_converting_constructor_from_other_policy (0 ms)
[----------] 1 test from threads (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (0 ms total)
[  PASSED  ] 1 test.

Test from #3497 is passing again :)

Copy link
Contributor

@DavidPoliakoff DavidPoliakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants