Used the Kokkos Profiling interface rather than the Impl interface

[DavidPoliakoff]

There was one place left where we directly called beginParallelFor. As we expand what can happen inside beginParallelFor, that is going to become more and more of a problem. Requesting a review from @crtrott because there's like a 1% chance it used the Impl interface for a specific reason I wasn't able to figure out

[DavidPoliakoff]

I'm out for the day, but I do exactly that pattern (create before, construct in first, use in second) elsewhere, so I'll do that here

…

On Thu, Oct 22, 2020 at 4:39 PM Christian Trott ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In core/src/impl/Kokkos_ViewMapping.hpp <#3518 (comment)>: > + auto functor_name = + (destroy ? "Kokkos::View::destruction [" + name + "]" + : "Kokkos::View::initialization [" + name + "]"); no I don't want the string construction happen if you are not inside the "Do I have profiling on" block. I mean I guess we could explicitly create a std::string before entering the blocks, and then assign inthe first and reuse in the second. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3518 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAGLSISEFRO5AKL53SYEFLSMC7CFANCNFSM4S3RKHIA> .

-- Thanks, David

[DavidPoliakoff]

@crtrott I can't see if your review had any other comments (GitHub literally isn't loading them), but I think I've addressed the ones I can find