Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIP] Fix atomics of large data types and clean up lock arrays #3529

Merged
merged 3 commits into from
Oct 29, 2020
Merged

[HIP] Fix atomics of large data types and clean up lock arrays #3529

merged 3 commits into from
Oct 29, 2020

Conversation

Rombur
Copy link
Member

@Rombur Rombur commented Oct 27, 2020

This PR:

  • cleans up the use of the global lock arrays:
    • hipcc now supports the use global variable in a namespace
    • remove a local lock arrays variable that was used as a workaround
  • enables the atomic of large data types
  • enables the last disabled test file for HIP

With this PR all the test files are enable with HIP but there are still a few tests in these files that are disabled/modified for HIP.

masterleinad
masterleinad approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

dalg24
dalg24 approved these changes Oct 27, 2020
View reviewed changes
core/unit_test/CMakeLists.txt
LIST(REMOVE_ITEM HIP_SOURCES
${CMAKE_CURRENT_BINARY_DIR}/hip/TestHIP_AtomicOperations_complexdouble.cpp
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@dalg24
Copy link
Member

dalg24 commented Oct 27, 2020

Retest this please

@dalg24
Copy link
Member

dalg24 commented Oct 28, 2020

Please squash 3a3d0c4 into fd040b4

@Rombur
Copy link
Member Author

Rombur commented Oct 28, 2020

Retest this please

@crtrott crtrott merged commit 2fe565a into kokkos:develop Oct 29, 2020
@Rombur Rombur deleted the new_complex branch November 11, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@masterleinad masterleinad masterleinad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rombur @dalg24 @masterleinad @crtrott