Fix windows build issues which crept in for the CUDA build. #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crtrott
force-pushed
the
fix-windows-cuda
branch
from
c90dd5f
to
aff6c20
Compare
dalg24
reviewed
Oct 28, 2020
| @@ -104,7 +104,8 @@ | |||
| #if !defined(KOKKOS_DISABLE_CUDA_ASM) | |||
| #if !defined(KOKKOS_ENABLE_CUDA_ASM) | |||
| #define KOKKOS_ENABLE_CUDA_ASM | |||
| #if !defined(KOKKOS_DISABLE_CUDA_ASM_ATOMICS) | |||
| #if !defined(KOKKOS_DISABLE_CUDA_ASM_ATOMICS) && \ | |||
| defined(KOKKOS_ENABLE_GNU_ATOMICS) | |||
There was a problem hiding this comment.
Can you elaborate on this change and explain what was wrong?
There was a problem hiding this comment.
CUDA_ASM uses GNU Atomics macros for memory orders and so we can't do this in windows with clang.
dalg24
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.