-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove integer_sequence backward compatibility implementation #3533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me if it passes CI
@dalg24 we can actually just pull all of our |
37d8e91
to
b81e913
Compare
Didn't find any match in Kokkos-Kernels nor Trilinos |
This is an issue with how EDG handles alias templates with respect to function template matching. I've run in to this before and I'll fix it as soon as I'm in front of my machine again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
c9919c2
to
3947ee2
Compare
Retest this please |
should be easy to fix after rebasing. |
3947ee2
to
e71d2c9
Compare
diff --git a/core/src/impl/KokkosExp_IterateTileGPU.hpp b/core/src/impl/KokkosExp_IterateTileGPU.hpp
index 5ca1f245e..688afcc10 100644
--- a/core/src/impl/KokkosExp_IterateTileGPU.hpp
+++ b/core/src/impl/KokkosExp_IterateTileGPU.hpp
@@ -81,7 +81,7 @@ _tag_invoke(Functor const& f, Args&&... args) {
template <class Tag, class Functor, class T, size_t N, size_t... Idxs,
class... Args>
KOKKOS_IMPL_FORCEINLINE_FUNCTION void _tag_invoke_array_helper(
- Functor const& f, T (&vals)[N], integer_sequence<size_t, Idxs...>,
+ Functor const& f, T (&vals)[N], std::integer_sequence<size_t, Idxs...>,
Args&&... args) {
_tag_invoke<Tag>(f, vals[Idxs]..., (Args &&) args...);
}
@@ -90,7 +90,7 @@ template <class Tag, class Functor, class T, size_t N, class... Args>
KOKKOS_IMPL_FORCEINLINE_FUNCTION void _tag_invoke_array(Functor const& f,
T (&vals)[N],
Args&&... args) {
- _tag_invoke_array_helper<Tag>(f, vals, make_index_sequence<N>{},
+ _tag_invoke_array_helper<Tag>(f, vals, std::make_index_sequence<N>{},
(Args &&) args...);
} fixes this. |
e71d2c9
to
2964452
Compare
e3c17dd
to
7bdf623
Compare
Retest this please |
The failing SYCL CI is fixed by #3741. |
They're in namespace
Impl
and they're only used in the tests that test if they work.Removing
integer_sequence
make_integer_sequence_concat
index_sequence
make_index_sequence
integer_sequence_at
at
reverse_integer_sequence
exclusive_scan_integer_sequence
inclusive_scan_integer_sequence