Fix ROCm 3.9 build #3565
Merged
Fix ROCm 3.9 build #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
Nov 4, 2020
core/unit_test/TestTeamScratch.hpp
Outdated
| // FIXME_HIP the parallel_reduce in this test requires a team size larger than | ||
| // 256 | ||
| // FIXME_HIP the parallel_reduce in this test requires a team size larger than | ||
| // 256. Fixed in ROCm 3.9 | ||
| #ifdef KOKKOS_ENABLE_HIP |
There was a problem hiding this comment.
Did you consider doing #if defined KOKKOS_ENABLE_HIP && ???
dalg24
approved these changes
Nov 4, 2020
DavidPoliakoff
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes ROCm 3.9 build. I've also added a comment that when we switch to ROCm 3.9 we can enable one more test. With ROCm 3.9, we need to disable a single test (atomic complex). Everything else passes but we have couple of tests (currently disabled) that segfault in Kokkos destructor. This is the weird bug that we have reported earlier. ROCm 3.9 seems to have fixed quite a few of the register spill bugs that we had.
cc: @arghdos, @stanmoore1