Fixup silent pointless comparison with zero in checked_narrow_cast #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crtrott
approved these changes
Nov 4, 2020
masterleinad
reviewed
Nov 4, 2020
There was a problem hiding this comment.
https://godbolt.org/z/5T9sv1 would be an alternative (as proposed in #3527 (comment))
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
ndellingwood
approved these changes
Nov 4, 2020
dalg24
deleted the
checked_narrow_cast_pointless_comparison_with_zero_issue_3554
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3554
https://godbolt.org/z/svrjjY