SYCL parallel_for MDRangePolicy #3583
Conversation
masterleinad
force-pushed
the
sycl_md_parallel_for
branch
2 times, most recently
from
c774a6c
to
fc053a5
Compare
masterleinad
force-pushed
the
sycl_md_parallel_for
branch
from
5f9bf66
to
0220349
Compare
|
Retest this please. |
masterleinad
force-pushed
the
sycl_md_parallel_for
branch
from
0220349
to
90dbc0f
Compare
|
Retest this please. |
1 similar comment
|
Retest this please. |
|
This should be ready. |
masterleinad
requested review from
dalg24 and
nliber
and removed request for
dalg24
|
Only one of the HIP CI checks is timing out which I am pretty sure is unrelated. |
masterleinad
force-pushed
the
sycl_md_parallel_for
branch
2 times, most recently
from
55e17e8
to
eaf4308
Compare
| } | ||
| #endif | ||
| #if defined(KOKKOS_ENABLE_SYCL) | ||
| // FIXME_SYCL query the limit instead |
There was a problem hiding this comment.
How do you plan on getting that number?
There was a problem hiding this comment.
m_device.get_info<device::max_work_group_size>() should work.
| #else | ||
| range_type range(point_type{{0, 0, 0}}, point_type{{N0, N1, N2}}, | ||
| tile_type{{8, 8, 4}}); | ||
| #endif |
There was a problem hiding this comment.
Are you changing all these because m_prod_tile_dims > 256?
masterleinad
force-pushed
the
sycl_md_parallel_for
branch
from
d64f3e2
to
439245e
Compare
| const Policy m_policy; | ||
|
|
||
| ParallelFor() = delete; | ||
| ParallelFor& operator=(ParallelFor const&) = delete; |
There was a problem hiding this comment.
We should declare the copy/move constructor and move assignment operator as deleted and the destructor as defaulted (Rule of 5).
|
Please address #3583 (comment) |
masterleinad
force-pushed
the
sycl_md_parallel_for
branch
from
a1e553d
to
8dfbe33
Compare
@dalg24 Here you go! |
|
All CI except for Travis has passed. |
Needs #3582.
So far only tested with the incremental test.