Adding OpenMPTarget parallel_scan #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore all the removed code in OpenMP_Parallel.hpp that was just dead (commented) code before. |
crtrott
commented
Dec 6, 2020
| typename std::enable_if< std::is_same< TagType , void >::value >::type | ||
| exec_range( const FunctorType & functor | ||
| , const Member ibeg , const Member iend | ||
| , reference_type update , const bool final ) |
There was a problem hiding this comment.
Note: all the removed code is irrelevant. That was dead (commented code) from the original CPU OpenMP backend).
crtrott
commented
Dec 6, 2020
| @@ -465,6 +466,51 @@ class ParallelScan<FunctorType, Kokkos::RangePolicy<Traits...>, | |||
| //---------------------------------------- | |||
| }; | |||
|
|
|||
| template <class FunctorType, class ReturnType, class... Traits> | |||
There was a problem hiding this comment.
I hope you guys are proud how I avoided duplicated code :-)
dalg24
requested changes
Dec 9, 2020
masterleinad
reviewed
Dec 9, 2020
| #pragma omp for | ||
| for (int i = 0; i < chunk_size; i++) { | ||
| int64_t idx = local_offset + i; | ||
| if (idx < N) a_functor(idx, element_values(team_id, i), false); |
There was a problem hiding this comment.
Shouldn't idx be of type Policy::index_type?
| if (omp_get_thread_num() == 0) { | ||
| value_type sum = 0; | ||
| for (int i = 0; i < chunk_size; i++) { | ||
| sum += element_values(team_id, i); |
There was a problem hiding this comment.
Why isn't this ValueJoin::join?
| value_type sum = 0; | ||
| for (int i = 0; i < chunk_size; i++) { | ||
| sum += element_values(team_id, i); | ||
| element_values(team_id, i) = sum; |
There was a problem hiding this comment.
we don't support array type scans so I think its not needed.
|
Added WorkTag too. |
masterleinad
approved these changes
Dec 16, 2020
dalg24
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.