Change SYCLInternal::m_queue std::unique_ptr -> std::optional #3677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to an optional<sycl::queue>. Ideally, it should just be a sycl::queue directly, but given current issues with assignability under SYCL+CUDA, this is the best we can do right now. Because it was initially developed under C++14, unique_ptr was used (as optional wasn't there), but it is better to have fewer heap allocations, instead of unnecessary ones.
dalg24
approved these changes
Dec 18, 2020
dalg24
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SYCLInternal, changed m_queue from a
unique_ptr<sycl::queue>to anoptional<sycl::queue>.Ideally, it should just be a
sycl::queuedirectly, but givencurrent issues with assignability under SYCL+CUDA, this is
the best we can do right now.
Because it was initially developed under C++14,
unique_ptrwas used (as
optionalwasn't there), but it is better tohave fewer heap allocations, instead of unnecessary ones.