Require CMake >=3.16 #3679
Require CMake >=3.16 #3679
Conversation
| IF(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.12.0") | ||
| CMAKE_POLICY(SET CMP0074 NEW) | ||
| ENDIF() | ||
| CMAKE_POLICY(SET CMP0074 NEW) |
There was a problem hiding this comment.
I actually wonder if we still need that guy
There was a problem hiding this comment.
https://cmake.org/cmake/help/latest/policy/CMP0074.html still says
[...]
This policy was introduced in CMake version 3.12. CMake version 3.19.2 warns when the policy is not set and uses OLD behavior. Use the cmake_policy() command to set it to OLD or NEW explicitly.
There was a problem hiding this comment.
Look at the comment above that block of code. The policy is being set in the main CMakeLists.txt of the package
masterleinad
force-pushed
the
require_cmake_3_17_1
branch
from
320c020
to
c77e264
Compare
masterleinad
force-pushed
the
require_cmake_3_17_1
branch
from
e1dab2c
to
d965d49
Compare
|
Retest this please. |
3 similar comments
|
Retest this please. |
|
Retest this please. |
|
Retest this please. |
| @@ -45,6 +45,26 @@ matrix: | |||
| compiler: gcc | |||
| env: CMAKE_BUILD_TYPE=Release BACKEND="OPENMP" | |||
|
|
|||
| # Install newer CMake. The distribution comes with CMake 3.12.4 but we require at least 3.16 | |||
| install: | |||
| - CMAKE_VERSION=3.17.1 | |||
There was a problem hiding this comment.
Why not:
DISTRIB_CODENAME=$(cat /etc/lsb-release | grep DISTRIB_CODENAME | awk -F '=' '{print $NF}')
wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc | apt-key add -
apt-add-repository "deb https://apt.kitware.com/ubuntu/ ${DISTRIB_CODENAME} main"
There was a problem hiding this comment.
I just copied from our Dockerfiles. We could try your suggestions but it doesn't matter as long as we don't activate Travis again.
In accordance with trilinos/Trilinos#8401, we also decided to require CMake 3.16 or higher.