-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable examples for SYCL #3691
Enable examples for SYCL #3691
Conversation
a33c612
to
ca82f1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not happy with the changes to explicit size_t. Folks should not use size_t for loop counters since its often bad for performance. Rather cast the return of extent. These examples generally should reflect best practices.
Doesn't it make more sense then to let |
I had the same initial reaction than you but then I look at kokkos/core/src/Kokkos_View.hpp Lines 655 to 660 in 78538c8
|
I guess this is a bigger discussion that we might not need to have here. For now, I just cast the upper bounds instead. |
Ready from my side. Needs more reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Again, I would prefer using #3615 instead of commenting all the printfs.
I disagree here. I don't think we want users to use that macro.
Yes, that's true. |
The return type for
extent
issize_t
.Again, I would prefer using #3615 instead of commenting all the
printf
s.