-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable more SYCL perf_tests #3692
Enable more SYCL perf_tests #3692
Conversation
sycl::ONEAPI::atomic_fence(sycl::ONEAPI::memory_order::acq_rel, | ||
sycl::ONEAPI::memory_scope::device); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need/want memory_order::seq_cst
or memory_scope::system
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what you did is right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
f8dfc4c
to
eb85894
Compare
Ready from my side. @crtrott's blocking review should be addressed. Needs more reviews. |
No description provided.