Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use drand instead of frand in drand #3696

Merged
merged 1 commit into from
Jan 5, 2021
Merged

use drand instead of frand in drand #3696

merged 1 commit into from
Jan 5, 2021

Conversation

jlippuner
Copy link
Contributor

double drand(const double& start, const double& end) should not be based on frand.

@dalg24-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

masterleinad
masterleinad approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@dalg24
Copy link
Member

dalg24 commented Jan 4, 2021

OK to test

crtrott
crtrott approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@crtrott crtrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah typo in the XorShift1024, was actually correct in XorShift64.

@crtrott crtrott merged commit 319acf1 into kokkos:develop Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@crtrott crtrott crtrott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jlippuner @dalg24-jenkins @dalg24 @masterleinad @crtrott