Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VERSION and SOVERSION to KOKKOS_INTERNAL_ADD_LIBRARY #3706

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

jrmadsen
Copy link
Contributor

@jrmadsen jrmadsen commented Jan 6, 2021

The question here is whether we want the SOVERSION to be ${Kokkos_VERSION_MAJOR} or ${Kokkos_VERSION_MAJOR}.${Kokkos_VERSION_MINOR}. The answer probably boils down to whether we want to "guarantee" new minor versions don't introduce new symbols which must be directly linked to. Given all the templates, I went ahead and assumed that would be difficult to enforce so I set SOVERSION to use the major and minor version (but we can change this).

Previously, we had:

libkokkoscore.3.3.0.so
libkokkoscore.so -> libkokkoscore.3.3.0.so

This produces:

libkokkoscore.3.3.0.so
libkokkoscore.3.3.so -> libkokkoscore.3.3.0.so
libkokkoscore.so -> libkokkoscore.3.3.so

Closes #3687

@dalg24 dalg24 requested a review from jjwilke January 7, 2021 14:19
@crtrott crtrott merged commit ff1613a into kokkos:develop Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants