Allow using tagged final functor in parallel_reduce #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
allow_tagged_final_in_reduce
branch
from
1ba8ceb
to
fbf04b6
Compare
dalg24
reviewed
Jan 13, 2021
Comment on lines
2094
to
2096
| template <typename Dummy = ArgTag> | ||
| KOKKOS_FORCEINLINE_FUNCTION static std::enable_if_t< | ||
| std::is_same<Dummy, void>::value> |
There was a problem hiding this comment.
This works but departs from what is done above for FunctorValueInit and FunctorValueJoin where two separate specializations are provided.
There was a problem hiding this comment.
Yes, this seems to be less code so I went with this approach.
There was a problem hiding this comment.
If you insist, I can change, of course.
There was a problem hiding this comment.
I would prefer consistency within that file but I will not block if I am the only one feeling that way.
masterleinad
force-pushed
the
allow_tagged_final_in_reduce
branch
from
eb4c5c0
to
9403ab9
Compare
|
Ready from my side. Needs more reviews. |
crtrott
approved these changes
Jan 14, 2021
dalg24
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3651.