Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for -Wno-deprecated-gpu-targets #3722

Merged

Conversation

jstrzebonski
Copy link

The flag -Wno-deprecated-gpu-targets seems to be ignored, here's a snippet from the compilation of DARMA-tasking/vt:

$ /usr/bin/ccache /nvcc_wrapper/build/nvcc_wrapper \
  -DFMT_HEADER_ONLY=1 -DFMT_USE_USER_DEFINED_LITERALS=0 \
  -DHAS_DETECTION_COMPONENT=1 -I/vt/lib/fmt -I/vt/lib/CLI -I/vt/lib/libfort/lib -Idebug -I/vt/src \
  -isystem /build/checkpoint/install/include -isystem /build/detector/install/include -Wall -pedantic -Wshadow \
  -Wno-unknown-pragmas -Wsign-compare -ftemplate-backtrace-limit=100 \
  -Wno-deprecated-gpu-targets -g -fdiagnostics-color=always -fPIC -fopenmp -std=c++14 \
  -MD -MT examples/callback/CMakeFiles/callback.dir/Unity/unity_0_cxx.cxx.o \
  -MF examples/callback/CMakeFiles/callback.dir/Unity/unity_0_cxx.cxx.o.d \
  -o examples/callback/CMakeFiles/callback.dir/Unity/unity_0_cxx.cxx.o \
  -c examples/callback/CMakeFiles/callback.dir/Unity/unity_0_cxx.cxx

nvcc warning : The 'compute_35', 'compute_37', 'compute_50', 'sm_35', 'sm_37' and 'sm_50' architectures are deprecated, and may be removed in a future release (Use -Wno-deprecated-gpu-targets to suppress warning).

As you can see, even though the flag is present, the compiler still complains about deprecated architectures.

This PR fixes the problem.

@dalg24-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@masterleinad
Copy link
Contributor

This looks OK to me but is it intentional that you don't specify the GPU architecture you wan't to compile for but use the default one (which turns out to be deprecated)?

@PhilMiller
Copy link
Contributor

Yeah, we're using this in the context of quieting CI scripts for code that's 100% host side, but needs to not confuse nvcc as it passes through.

@dalg24
Copy link
Member

dalg24 commented Jan 13, 2021

OK to test

Copy link
Contributor

@DavidPoliakoff DavidPoliakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@crtrott crtrott merged commit a07a010 into kokkos:develop Jan 13, 2021
@jstrzebonski jstrzebonski deleted the add-Wno-deprecated-gpu-targets branch February 4, 2021 16:02
@jstrzebonski jstrzebonski restored the add-Wno-deprecated-gpu-targets branch February 4, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants