Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing bug for number of devices command line argument #3724

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Jan 13, 2021

Introduced in #3718
Reported by @stanmoore1

@dalg24 dalg24 added Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) DevelopOnly labels Jan 13, 2021
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Copy link
Contributor

@DavidPoliakoff DavidPoliakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++:beer:-we-owe-stan

@dalg24
Copy link
Member Author

dalg24 commented Jan 13, 2021

Retest this please (does not seem to have triggered a build on Jenkins)

@masterleinad
Copy link
Contributor

Looks like it passed CI.

@dalg24 dalg24 merged commit 28cd4bf into kokkos:develop Jan 14, 2021
@dalg24 dalg24 deleted the bugfix_num_devices branch January 19, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants