Enable SYCL atomic tests #3742
Merged
Enable SYCL atomic tests #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
sycl_atomic_tests
branch
from
425cf80
to
754ab97
Compare
dalg24
requested changes
Jan 27, 2021
| @@ -45,6 +45,8 @@ | |||
| #include <TestAtomicOperations.hpp> | |||
|
|
|||
| namespace Test { | |||
| // FIXME_SYCL atomic_fetch_oper for large types to be implemented | |||
| #ifndef KOKKOS_ENABLE_SYCL | |||
There was a problem hiding this comment.
Why do you remove it from the list if everything is being commented out?
There was a problem hiding this comment.
So that I have a better description for the FIXME.
There was a problem hiding this comment.
If you feel really strongly about it I can remove it but I prefer to have tests in core/unit/CMakeLists.txt that I have not looked at and found a better description.
There was a problem hiding this comment.
I prefer tests which completely not work to be removed in cmake
There was a problem hiding this comment.
You can have the comment in the CMakeLists.txt right next to the unit test you remove from the list
dalg24
approved these changes
Jan 28, 2021
|
Retest this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3741.