Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable some more SYCL tests #3744

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Enable some more SYCL tests #3744

merged 1 commit into from
Feb 2, 2021

Conversation

masterleinad
Copy link
Contributor

Based on #3741.

@masterleinad masterleinad changed the title Split SYCL tests for aot compilationSycl enable more tests Enable some more SYCL tests Jan 22, 2021
@masterleinad masterleinad marked this pull request as ready for review January 27, 2021 21:43
dalg24
dalg24 requested changes Jan 27, 2021
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with the DynamicView changes

Why is Reductions_DeviceView not in the list(REMOVE_ITEM SYCL_SOURCES1B ...)?
The unit test seems pointless with the #ifdefs. What am I missing?

@masterleinad
Copy link
Contributor Author

Why is Reductions_DeviceView not in the list(REMOVE_ITEM SYCL_SOURCES1B ...)?

There was already reduce_device_view_range_policy that was working.

The unit test seems pointless with the #ifdefs. What am I missing?

On second thought, I agree that it makes more sense to disable it. I still improved the FIXME description and let the functor compile so we can check that at least compiling it works fine.

dalg24
dalg24 approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash the two commits before we merge

@masterleinad
Copy link
Contributor Author

Squash the two commits before we merge

Here you go.

@dalg24 dalg24 merged commit 5a0b850 into kokkos:develop Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masterleinad @dalg24