Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/Cuda: Half_t updates for cgsolve #3746

Merged
merged 1 commit into from
Feb 5, 2021
Merged

core/Cuda: Half_t updates for cgsolve #3746

merged 1 commit into from
Feb 5, 2021

Conversation

e10harvey
Copy link
Contributor

@e10harvey e10harvey commented Jan 23, 2021 •
edited

  • Support for volatile arithmetic in compound add, subtract, multiply, and divide
  • Support volatile assignment

Related to kokkos/kokkos-kernels#852.

@e10harvey e10harvey mentioned this pull request Jan 23, 2021
Merged
@e10harvey e10harvey changed the title core/Cuda: Initial support for half_t volatile operations core/Cuda: Half_t updates for cgsolve Jan 23, 2021
@e10harvey e10harvey mentioned this pull request Jan 23, 2021
Closed
2 tasks
crtrott
crtrott requested changes Jan 26, 2021
View reviewed changes
core/src/Cuda/Kokkos_Cuda_Half.hpp Outdated Show resolved Hide resolved
@e10harvey
Copy link
Contributor Author

retest this please

dalg24
dalg24 reviewed Jan 29, 2021
View reviewed changes
core/src/Cuda/Kokkos_Cuda_Half.hpp Outdated Show resolved Hide resolved
core/src/Cuda/Kokkos_Cuda_Half.hpp Show resolved Hide resolved
core/src/Cuda/Kokkos_Cuda_Half.hpp Outdated Show resolved Hide resolved
crtrott
crtrott requested changes Feb 2, 2021
View reviewed changes
Copy link
Member

@crtrott crtrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the clarity improvement its fine. Do we know why the formatting change happened?

core/src/Cuda/Kokkos_Cuda_Half.hpp Outdated Show resolved Hide resolved
@e10harvey
Copy link
Contributor Author

other than the clarity improvement its fine. Do we know why the formatting change happened?

I made the clarity improvement. The formatting must have been done by clang-format; not sure why that changed as I ran it the same way as before.

dalg24
dalg24 reviewed Feb 2, 2021
View reviewed changes
core/src/Cuda/Kokkos_Cuda_Half.hpp Outdated Show resolved Hide resolved
core/src/Cuda/Kokkos_Cuda_Half.hpp Outdated Show resolved Hide resolved
core/src/Cuda/Kokkos_Cuda_Half.hpp Outdated Show resolved Hide resolved
core/src/Cuda/Kokkos_Cuda_Half.hpp Outdated Show resolved Hide resolved
core/src/Cuda/Kokkos_Cuda_Half.hpp Outdated Show resolved Hide resolved
core/src/Cuda/Kokkos_Cuda_Half.hpp Outdated Show resolved Hide resolved
core/src/Cuda/Kokkos_Cuda_Half.hpp Outdated Show resolved Hide resolved
@e10harvey
core/Cuda: Half_t updates for cgsolve
01785ad 
  - Support for volatile arithmetic in compound add, subtract, multiply, and
  divide
  - Support volatile assignment

Related to kokkos/kokkos-kernels#852.
@e10harvey
Copy link
Contributor Author

retest this please

@crtrott crtrott merged commit 4af9349 into kokkos:develop Feb 5, 2021
@e10harvey e10harvey deleted the half-cgsolve-updates branch July 23, 2021 15:50
@e10harvey e10harvey self-assigned this Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@crtrott crtrott crtrott approved these changes

Assignees

@e10harvey e10harvey

Labels
None yet
Projects
Developer: E10HARVEY
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@e10harvey @dalg24 @crtrott