Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3739 Fixed Kokkos_install_additional_files macro #3752

Merged
merged 1 commit into from
Feb 5, 2021
Merged

#3739 Fixed Kokkos_install_additional_files macro #3752

merged 1 commit into from
Feb 5, 2021

Conversation

lkersting
Copy link
Contributor

The Kokkos_install_additional_files macro incorrectly installed the additional header files when HAS_PARENT was true.

@lkersting
kokkos#3739 Fixed Kokkos_install_additional_files macro
13844be 
The Kokkos_install_additional_files macro incorrectly installed the additional header files when HAS_PARENT was true.
@dalg24-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@dalg24
Copy link
Member

dalg24 commented Jan 26, 2021

OK to test

masterleinad
masterleinad approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

jrmadsen
jrmadsen approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@jrmadsen jrmadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right based on what KOKKOS_HEADER_DIR is set to but I feel like some installs going to include/kokkos and other going to include is a recipe for having two different header installs of kokkos and one set of libraries...

@crtrott crtrott merged commit 7934e86 into kokkos:develop Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@masterleinad masterleinad masterleinad approved these changes

@jrmadsen jrmadsen jrmadsen approved these changes

@jjwilke jjwilke Awaiting requested review from jjwilke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lkersting @dalg24-jenkins @dalg24 @masterleinad @jrmadsen @crtrott