Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative implementation for SYCL TeamPolicy #3759

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Alternative implementation for SYCL TeamPolicy #3759

merged 2 commits into from
Feb 5, 2021

Conversation

masterleinad
Copy link
Contributor

SYCL implements hierarchical parallelism with a fork-join model that doesn't much the Kokkos model. This pull request provides an alternative implementation that doesn't use parallel_for_work_group/parallel_for_work_item.

@masterleinad masterleinad mentioned this pull request Jan 29, 2021
Merged
@masterleinad masterleinad mentioned this pull request Feb 1, 2021
Merged
@masterleinad masterleinad added the Blocks Promotion Overview issue for release-blocking bugs label Feb 3, 2021
crtrott
crtrott approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@crtrott crtrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I read this correct this actually is the correct mapping isn't it? I.e. if the nd_item actually has a barrier?

@crtrott crtrott merged commit 79627da into kokkos:develop Feb 5, 2021
@masterleinad
Copy link
Contributor Author

If I read this correct this actually is the correct mapping isn't it? I.e. if the nd_item actually has a barrier?

Yes. Thanks for confirming that this is what we want.

@masterleinad masterleinad deleted the sycl_team_policy_alternative branch February 5, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@nliber nliber nliber approved these changes

@crtrott crtrott crtrott approved these changes

Assignees
No one assigned
Labels
Blocks Promotion Overview issue for release-blocking bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@masterleinad @dalg24 @nliber @crtrott