Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated comments and enabled no-op for kokkos_launch_compiler #3774

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

jrmadsen
Copy link
Contributor

@jrmadsen jrmadsen commented Feb 2, 2021

  • Fixes comments in KokkosConfig.cmake.in w.r.t. the behavior of kokkos_launch_compiler
  • Updated KokkosConfigCommon.cmake.in to encode @Kokkos_ENABLE_CUDA@ so that if called when Kokkos was not built with CUDA support, the command is ignored (since it would be an error)

Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonsable.

@dalg24 dalg24 merged commit 762cc55 into kokkos:develop Feb 3, 2021
@jrmadsen jrmadsen deleted the kokkos-launch-compiler-updates branch February 3, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants