Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate sycl_indirect_launch #3777

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Eliminate sycl_indirect_launch #3777

merged 1 commit into from
Feb 10, 2021

Conversation

masterleinad
Copy link
Contributor

We can avoid the indirection through sycl_indirect_launch if we just wrap the functor appropriately to have a container that

  1. can store the unique_ptr if necessary and
  2. can return the functor we want to forward to sycl_direct_launch

This avoids us writing the same code for sycl_indirect_launch all the time.

@masterleinad masterleinad force-pushed the eliminate_sycl_indirect_launch branch 2 times, most recently from 9f5d883 to 37d4a74 Compare February 5, 2021 17:53
@masterleinad
Copy link
Contributor Author

Retest this please.

dalg24
dalg24 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a big fan of (*(m_policy.space()).impl_internal_space_instance()).m_indirectKernelMem but looks good other than that.

dalg24
dalg24 requested changes Feb 9, 2021
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up history and I will merge

dalg24
dalg24 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you decide on squashing everything you can tell me and I can do it when I merge

@masterleinad
Copy link
Contributor Author

When you decide on squashing everything you can tell me and I can do it when I merge

Sure.

@dalg24 dalg24 merged commit f63e5c9 into kokkos:develop Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@nliber nliber nliber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@masterleinad @dalg24 @nliber