Prefer -std=* over --std=*

[masterleinad]

AFAICT -std=* is more standard then --std=* and ICC doesn't seem to like the latter, see https://godbolt.org/z/e6Wshq. In particular, @stanmoore1 was running into an issue as reported in slack.

[dalg24]

Test this please

[masterleinad]

Retest this please.

[crtrott]

did we test this with older iccs and various clang?

[dalg24]

did we test this with older iccs and various clang?

No, we have very limited testing for the generated makefiles

[masterleinad]

did we test this with older iccs and various clang?

I manually went through all iccs that support C++14 I could find on godbolt (which is >=16.0.3)
and all clangs ( >=3.5). I always at least get a warning for icc with --std, also see https://software.intel.com/content/www/us/en/develop/documentation/cpp-compiler-developer-guide-and-reference/top/compiler-reference/compiler-options/compiler-option-details/language-options/std-qstd.html, but clang accepts both for all versions.

[dalg24]

Daniel beats me there. I can confirm what he said