Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Atomic{Min,Max} for Kepler30 #3780

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Fix Atomic{Min,Max} for Kepler30 #3780

merged 1 commit into from
Feb 11, 2021

Conversation

janciesko
Copy link
Contributor

@janciesko janciesko commented Feb 4, 2021 •
edited

  • Allows to maintain support for Kepler (Compute Capability 3.0)
  • Uses fallbacks for atomic min and max ops.

@janciesko janciesko mentioned this pull request Feb 4, 2021
Closed
masterleinad
masterleinad reviewed Feb 4, 2021
View reviewed changes
core/src/Cuda/Kokkos_Cuda_View.hpp Outdated
@@ -139,7 +139,7 @@ struct CudaLDGFetch {

template <typename iType>
KOKKOS_INLINE_FUNCTION ValueType operator[](const iType& i) const {
#ifdef __CUDA_ARCH__
#if defined(__CUDA_ARCH__) && !defined(KOKKOS_ARCH_KEPLER30)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about KOKKOS_ARCH_KEPLER32?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KOKKOS_ARCH_KEPLER32 works a no changes needed.

dalg24
dalg24 requested changes Feb 4, 2021
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot Kepler32

core/src/Cuda/Kokkos_Cuda_View.hpp Outdated
@@ -139,7 +139,7 @@ struct CudaLDGFetch {

template <typename iType>
KOKKOS_INLINE_FUNCTION ValueType operator[](const iType& i) const {
#ifdef __CUDA_ARCH__
#if defined(__CUDA_ARCH__) && !defined(KOKKOS_ARCH_KEPLER30)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#if defined(__CUDA_ARCH__) && !defined(KOKKOS_ARCH_KEPLER30)
#if defined(__CUDA_ARCH__) && (__CUDA_ARCH__ >= 350)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

320

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation says "only supported by devices of compute capability 3.5 and higher"

core/src/impl/Kokkos_Atomic_MinMax.hpp Outdated
@@ -101,6 +101,52 @@ inline __host__ unsigned long long int atomic_fetch_max(

#endif

#if defined(KOKKOS_ARCH_KEPLER30)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#if defined(KOKKOS_ARCH_KEPLER30)
#if defined(__CUDA_ARCH__) && (__CUDA_ARCH__ < 350)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

core/src/impl/Kokkos_Atomic_MinMax.hpp Outdated
dest, val);
}

#else //(!KOKKOS_ARCH_KEPLER30)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#else //(!KOKKOS_ARCH_KEPLER30)
#else // supported by devices of compute capability 3.5 and higher

core/src/impl/Kokkos_Atomic_MinMax.hpp Outdated
@@ -178,6 +226,52 @@ inline __host__ unsigned long long int atomic_max_fetch(
}
#endif

#if defined(KOKKOS_ARCH_KEPLER30)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#if defined(KOKKOS_ARCH_KEPLER30)
#if defined(__CUDA_ARCH__) && (__CUDA_ARCH__ < 350)

core/src/impl/Kokkos_Atomic_MinMax.hpp Outdated
dest, val);
}

#else //(!KOKKOS_ARCH_KEPLER30)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#else //(!KOKKOS_ARCH_KEPLER30)
#else // supported by devices of compute capability 3.5 and higher

@crtrott
Copy link
Member

crtrott commented Feb 5, 2021

Ok checked the 9.0 documentation: it looks like its just 64 bit integer atomics which are not supported pre 3.5, 32 bit ones seem to be fine (min/max/or/xor etc.)

@dalg24 dalg24 merged commit ee8ff17 into kokkos:develop Feb 11, 2021
@dalg24 dalg24 mentioned this pull request Feb 11, 2021
Closed
@dalg24 dalg24 mentioned this pull request Mar 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad left review comments

@dalg24 dalg24 dalg24 approved these changes

@DavidPoliakoff DavidPoliakoff DavidPoliakoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@janciesko @crtrott @dalg24 @masterleinad @DavidPoliakoff