OpenMPTarget: MDRange with TagType for parallel_for. #3781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgayatri23
added
the
Feature Request
dalg24
approved these changes
Feb 5, 2021
| @@ -263,8 +282,12 @@ class ParallelFor<FunctorType, Kokkos::MDRangePolicy<Traits...>, | |||
| for (ptrdiff_t i0 = begin_0; i0 < end_0; i0++) | |||
| for (ptrdiff_t i1 = begin_1; i1 < end_1; i1++) | |||
| for (ptrdiff_t i2 = begin_2; i2 < end_2; i2++) | |||
| for (ptrdiff_t i3 = begin_3; i3 < end_3; i3++) | |||
| functor(i0, i1, i2, i3); | |||
| for (ptrdiff_t i3 = begin_3; i3 < end_3; i3++) { | |||
There was a problem hiding this comment.
I would prefer you being consistent with the curly brace. Put everywhere or nowhere.
crtrott
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes :
Feature needed for lammps.