Avoid duplicated code in ScratchMemorySpace #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
remove_duplicate_scratch_memory_space
branch
from
7d1e9da
to
2aace23
Compare
dalg24
approved these changes
Feb 10, 2021
dalg24
requested changes
Feb 10, 2021
| } | ||
|
|
||
| template <bool aligned, typename IntType> | ||
| KOKKOS_INLINE_FUNCTION void* get_shmem_common(const IntType& size, |
There was a problem hiding this comment.
Actually make that guy private or prefix with impl_
dalg24
approved these changes
Feb 11, 2021
Rombur
approved these changes
Feb 15, 2021
ndellingwood
added a commit
to ndellingwood/kokkos
that referenced
this pull request
Apr 22, 2021
Some changes of PR kokkos#3793 that removed code duplication in scratch memory resulted in seg faults (when compiled with intel/18 compilers) of executables utilizing hierarchical parallelism when the team handle was passed by value rather than by reference and accessing/writing to views within the lambda body This PR reverts the changes that replaced m_iter_L0, m_iter_L1, m_end_L0, m_iter_L1 by arrays m_iter_L and m_end_L and adds a unit test that reproduced the issue
ndellingwood
added a commit
to ndellingwood/kokkos
that referenced
this pull request
Apr 22, 2021
Some changes of PR kokkos#3793 that removed code duplication in scratch memory resulted in seg faults (when compiled with intel/18 compilers) of executables utilizing hierarchical parallelism when the team handle was passed by value rather than by reference and accessing/writing to views within the lambda body This PR reverts the changes that replaced m_iter_L0, m_iter_L1, m_end_L0, m_iter_L1 by arrays m_iter_L and m_end_L and adds a unit test that reproduced the issue
ndellingwood
added a commit
to ndellingwood/kokkos
that referenced
this pull request
Apr 22, 2021
Some changes of PR kokkos#3793 that removed code duplication in scratch memory resulted in seg faults (when compiled with intel/18 compilers) of executables utilizing hierarchical parallelism when the team handle was passed by value rather than by reference and accessing/writing to views within the lambda body This PR reverts the changes that replaced m_iter_L0, m_iter_L1, m_end_L0, m_iter_L1 by arrays m_iter_L and m_end_L and adds a unit test that reproduced the issue
This was referenced Apr 22, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the code for
get_shmemandget_shmem_alignedcan be combined relatively easy avoiding code duplication also for level0/level1.