Fixed command line parsing bug #3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidPoliakoff
added
the
Blocks Promotion
crtrott
approved these changes
Feb 12, 2021
dalg24
reviewed
Feb 12, 2021
|
DavidPoliakoff@6d6982f removed it. |
|
Retest this please. |
masterleinad
approved these changes
Feb 12, 2021
|
@jrmadsen : SABOTEUR! Kidding ;) |
|
@masterleinad where are you getting that? It did get removed accidentally but I put it back in later commit. Develop shouldn't have that change at all (assuming the PR got squashed before merging). I think maybe @DavidPoliakoff's git history might have gotten messed up when he was testing that PR? |
|
Nope nevermind. I see it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, between
masteranddevelop, thenarg--from the kokkos-tune-internals got removed. This puts it back? Not sure how that happened