Remove ExtendedReferenceWrapper for SYCL parallel_reduce #3802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nliber
approved these changes
Feb 16, 2021
dalg24
reviewed
Feb 16, 2021
|
All the |
Yes, I'm hunting it down. |
|
Seems to work now. |
masterleinad
force-pushed
the
simplify_sycl_reduce
branch
from
c4b7943
to
5af0c58
Compare
dalg24
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that we actually don't need ExtendedReferenceWrapper if we are a bit more careful with the point when we set up the functor we actually want to run.
Using
std::reference_wrapperinstead also allows us to simplifymake_sycl_function_wrapperand we can remove some code inKokkos_FunctorAdapter.hpp, too.