Constructing Atomic Subviews #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View<double*> a("a",10);
auto range = std::pair(0,4);
auto s3 = subview<MemoryTraits<Atomic>>(a, range);
We get to down to:
ViewDataHandle (specialized for MemoryTraits<Atomic>)::
template <class SrcHandleType>
KOKKOS_INLINE_FUNCTION static handle_type assign(
const SrcHandleType& arg_handle, size_t offset) {
return handle_type(arg_handle.ptr + offset);
}
arg_handle is already a pointer (double*), so .ptr is incorrect.
the index for initializing the loop from int to size_type (aka size_t).
nliber
changed the title
|
Retest this please |
dalg24
approved these changes
Mar 17, 2021
|
Retest this please |
masterleinad
approved these changes
Mar 17, 2021
crtrott
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3765
We get to down to:
ViewDataHandle (specialized for MemoryTraits)::
arg_handle is already a pointer (double*), so .ptr is incorrect.
This fixes the compile time problem, but still needs run time test cases.