Replaced nanosleep and sched_yield with STL routines #3825
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KOKKOS_ENABLE_STDTHREAD
is probably old pre-C++11 code. It isn't defined anywhere so it was removedBenchmarked (via QuickBench:
vs.
and found the latter to be more efficient.
@crtrott Can you take a look at
HostBarrier::impl_backoff_wait_until_equal
as a whole? There is a weird#if !defined(_WIN32)
and the#else
for Windows doesn't seem to implement the same algorithm at all.